Skip to content

Add warning to when converting runner to specific

What does this MR do?

This change adds a simple warning to administrators when restricting a shared/instance runner as this operation is not reversible.

Note: This is a minimum viable change, this feature's UX should be revised but this helps users not fall into the "trap" to changing a runner type.

Screenshots or Screencasts (strongly suggested)

2021-08-25_15.24.34

How to setup and validate locally (strongly suggested)

  1. Visit any shared/instance runner from the admin section http://gdk.test:3000/admin/runners/97
  2. Select any project under "Restrict projects for this runner".

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #337413 (closed)

Edited by Miguel Rincon

Merge request reports