Implement `#new_blobs` via `#list_blobs`
What does this MR do?
In order to determine which blobs are new based on a given revision, we
call Gitaly's ListNewBlobs RPC. This RPC is rather inflexible though:
it only allows passing a single new revision. As a result, we cannot
batch computation of new blobs across a set changes in our access
checks.
As a first step towards fixing this limitation, we now migrate
#new_blobs() to use the ListBlobs RPC: this is a much more flexible
variant of ListNewBlobs, and most importantly it allows us to pass a
set of revisions. When the old implementation is removed, we can thus
easily allow #new_blobs() to receive multiple revisions.
Note that this changes the return type of #new_blobs(): instead of
returning a set of Gitaly::NewBlobObject classes, we now return a set
of Gitlab::Git::Blobs. While both share the same size and path
attributes, the former tracks the blob ID via an id attribute while
the latter uses an oid attribute. There is only a single callsite of
#new_blobs() though, which is the FileSizeCheck push rule, and this
callsite only uses the size and path attributes. So in the end, this
change in behaviour is fine.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team