Fix epic swimlanes list repositioning not working
What does this MR do?
Fixes the list reordering feature for issue boards in epic swimlanes.
Background
We use two Draggables in issue boards, one for issuable card and another for list.
We added a check to the handler (listMove vuex action) to ensure only the events fired by the Draggable for list
were handled using data-draggable-item-type attribute in !68126 (merged).
We (I @euko) forgot to add the data attribute to epic swimlane columns and this broke the drag&drop list reordering feature.
Screenshots or Screencasts (strongly suggested)
| before | after |
|---|---|
| Screen_Recording_2021-08-25_at_10.15.29_AM | Screen_Recording_2021-08-25_at_10.16.07_AM |
How to setup and validate locally (strongly suggested)
- Visit issue boards (project or group)
- Turn on the epic swimlanes by using the "Group by" toggle in the top right and selecting "Epic"
- Create two movable lists (labels, assignees, etc).
- Re-order the movable lists with drag&drop
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by euko