Fix pipeline status update in pipeline editor
What does this MR do?
Related to #335074 (closed).
We refactored the pipeline editor to fetch the commitSha
using graphql. This fixes a bug related to the refactor where the pipeline status does not update correctly when committing changes to the current branch.
When committing a new branch, it's possible that the pipeline data is not yet ready when the vue app fetches it, so we poll for the data until it is received. This is also the case for committing changes to the current branch (it seems we're fetching too early).
Since the bug fix is for a change that was released in the current milestone, no changelog trailers were added.
Screenshots or Screencasts
How to setup and validate locally (strongly suggested)
- Go to the Pipeline Editor in
CI/CD > Editor
, - At the bottom of the page, submit a commit to the same branch you are in.
- Wait a few seconds and verify that the pipeline status is updated with the new pipeline and commit.
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
Merge request reports
Activity
changed milestone to %14.3
added devopsverify frontend grouppipeline authoring sectionops typebug labels
assigned to @mgandres
1 Warning Reviewer roulette failed to load team data: Failed to parse JSON response from https://gitlab-org.gitlab.io/gitlab-roulette/roulette.json 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2c66e7b2 and dcf996f4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.13 MB 3.12 MB -1.06 KB -0.0 % mainChunk 1.85 MB 1.85 MB - -0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.compare.show 298.26 KB 305.98 KB +7.72 KB 2.6 % Significant Reduction: 4Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.audit_logs 462.5 KB 443.37 KB -19.14 KB -4.1 % pages.groups.audit_events 469.83 KB 450.69 KB -19.14 KB -4.1 % pages.projects.audit_events 602.09 KB 583.02 KB -19.07 KB -3.2 % pages.projects.analytics.code_reviews.index 623.99 KB 604.93 KB -19.06 KB -3.1 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 2c66e7b2. So we have used data from: 1b70d217.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for dcf996f4!review-qa-smoke:
test reportadded 1 commit
- 98d123e3 - Fix pipeline status update in pipeline editor
added 1 commit
- 48481806 - Fix pipeline status update in pipeline editor
- Resolved by Ezekiel Kigbo
@himkp could you give this the initial review?
requested review from @himkp
removed review request for @himkp
@himkp
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Ezekiel Kigbo
Hi @ekigbo could you maintain this please?
requested review from @ekigbo
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
- Resolved by Ezekiel Kigbo
added 329 commits
-
48481806...741c5eb2 - 327 commits from branch
master
- cde420bf - Fix pipeline status update in pipeline editor
- dcf996f4 - Add poll interval constant
-
48481806...741c5eb2 - 327 commits from branch
enabled an automatic merge when the pipeline for 06a796fb succeeds
mentioned in commit 5bc7fffe
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue gl-retrospectives/verify-stage/pipeline-authoring#11 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label