Skip to content

Use GraphQL to delete a note

Savas Vedova requested to merge 228745-use-graphql-to-delete-note into master

What does this MR do?

This MR changes the way we delete a history note in the vulnerability details page. It used to use a REST endpoint to perform the action, now it uses GraphQL.

Screenshots or Screencasts (strongly suggested)

There are no visual changes but here's a Screencast that shows the feature still working:

delete-comment

How to setup and validate locally (strongly suggested)

  1. Clone https://gitlab.com/gitlab-examples/security/security-reports/
  2. Run the pipeline by going into Your project > CI/CD > Pipelines
  3. Click on run pipeline for master branch
  4. Go to Security & Compliance > Vulnerability Report > Click on a Vulnerability
  5. Change the state, it will generate a history entry
  6. Add a note
  7. Delete the note

You should have the runner installed in order to run the pipeline. Then using the following command you can register the runner, it guides you pretty good on how to set the runner:

$ gitlab-runner register

Once it's installed this is how I run the runner:

$ gitlab-runner --log-level debug run local-runner --config ~/.gitlab-runner/config.toml restart

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #228745 (closed)

Merge request reports