Skip to content

Remove the duplicated `other_storage_counter` app

Ammar Alakkad requested to merge 334892-remove-other-storage-app into master

What does this MR do?

It removes the other_storage_counter app introduced in !57121 (merged) with all related changes. It's being removed because the main epic https://gitlab.com/groups/gitlab-org/-/epics/5488#note_654574160 has been marked as won't do and the introduced code won't be used anymore.

Note: the pipelines (danger) are failing because the MR removes a feature flag without adding a changelog, the reason we didn't add a changelog is that we're removing the feature flag and the code associated with it.

Screenshots

before after
Screen_Shot_2021-08-23_at_11.24.04_AM Screen_Shot_2021-08-23_at_11.23.22_AM

How to setup and validate locally (strongly suggested)

To validate before checking out the branch:

  1. enable `Feature.enabled(:other_storage_tab)
  2. visit a groups usage quotas groups/<ID>/-/usage_quotas
  3. observe the last tab "Other Storage"

To validate after checking out the branch:

  1. visit a groups usage quotas groups/<ID>/-/usage_quotas
  2. observe the last tab "Other Storage" is not there
  3. (optional) disable the feature flag Feature.disable(:other_storage_tab)

Does this MR meet the acceptance criteria?

Conformity

Related to #334892

Edited by Ammar Alakkad

Merge request reports