What does this MR do?
Drop un-used db/ci_migrate symlink
db/ci_migratesymlink is not currently used in production
- It was supposed to be used in development for the decomposition efforts. But it seems we don't need it for our current purposes, as Rails will default
Resolves #339079 (closed)
Screenshots or Screencasts (strongly suggested)
Impact on development.
With multiple databases, I was able to run
anddb:migrate:redo:main` for a new migration fine:
tkgl:gitlab tkuah$ be rails db:migrate:redo:ci == 20210823002133 AddSomeRandomTable: reverting =============================== -- drop_table(:randoms) -> 0.0049s == 20210823002133 AddSomeRandomTable: reverted (0.0079s) ====================== == 20210823002133 AddSomeRandomTable: migrating =============================== -- create_table(:randoms) -> 0.0086s == 20210823002133 AddSomeRandomTable: migrated (0.0087s) ====================== tkgl:gitlab tkuah$ be rails db:migrate:redo:main == 20210823002133 AddSomeRandomTable: reverting =============================== -- drop_table(:randoms) -> 0.0040s == 20210823002133 AddSomeRandomTable: reverted (0.0065s) ====================== == 20210823002133 AddSomeRandomTable: migrating =============================== -- create_table(:randoms) -> 0.0064s == 20210823002133 AddSomeRandomTable: migrated (0.0065s) ======================
gitlabhq_development=# \c gitlabhq_development_ci You are now connected to database "gitlabhq_development_ci" as user "tkuah". gitlabhq_development_ci=# \d randoms Table "public.randoms" Column | Type | Collation | Nullable | Default ------------+--------------------------+-----------+----------+------------------------------------- id | bigint | | not null | nextval('randoms_id_seq'::regclass) created_at | timestamp with time zone | | not null | updated_at | timestamp with time zone | | not null | Indexes: "randoms_pkey" PRIMARY KEY, btree (id)
- Enable the invite modal
- In rails console enable the experiment fully
- Visit any group or project member pages such as
Does this MR meet the acceptance criteria?
I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
I have added/updated documentation, or it's not needed. (Is documentation required?)
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
I have self-reviewed this MR per code review guidelines.
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
I have followed the style guides.
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
I have tested this MR in all supported browsers, or it's not needed.
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
Label as security and @ mention
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team