Drop un-used db/ci_migrate symlink

Merged Thong Kuah requested to merge drop_ci_migrate_symlink into master

What does this MR do?

Drop un-used db/ci_migrate symlink

  1. The db/ci_migrate symlink is not currently used in production
  2. It was supposed to be used in development for the decomposition efforts. But it seems we don't need it for our current purposes, as Rails will default migrations_paths to db_migrate anyway. See

Resolves #339079 (closed)

Screenshots or Screencasts (strongly suggested)

Impact on development.

With multiple databases, I was able to run db:migrate, db:migrate:redo:cianddb:migrate:redo:main` for a new migration fine:

tkgl:gitlab tkuah$ be rails db:migrate:redo:ci
== 20210823002133 AddSomeRandomTable: reverting ===============================
-- drop_table(:randoms)
   -> 0.0049s
== 20210823002133 AddSomeRandomTable: reverted (0.0079s) ======================

== 20210823002133 AddSomeRandomTable: migrating ===============================
-- create_table(:randoms)
   -> 0.0086s
== 20210823002133 AddSomeRandomTable: migrated (0.0087s) ======================


tkgl:gitlab tkuah$ be rails db:migrate:redo:main
== 20210823002133 AddSomeRandomTable: reverting ===============================
-- drop_table(:randoms)
   -> 0.0040s
== 20210823002133 AddSomeRandomTable: reverted (0.0065s) ======================

== 20210823002133 AddSomeRandomTable: migrating ===============================
-- create_table(:randoms)
   -> 0.0064s
== 20210823002133 AddSomeRandomTable: migrated (0.0065s) ======================
gitlabhq_development=# \c gitlabhq_development_ci
You are now connected to database "gitlabhq_development_ci" as user "tkuah".
gitlabhq_development_ci=# \d randoms
                                       Table "public.randoms"
   Column   |           Type           | Collation | Nullable |               Default               
------------+--------------------------+-----------+----------+-------------------------------------
 id         | bigint                   |           | not null | nextval('randoms_id_seq'::regclass)
 created_at | timestamp with time zone |           | not null | 
 updated_at | timestamp with time zone |           | not null | 
Indexes:
    "randoms_pkey" PRIMARY KEY, btree (id)

Example below:

  1. Enable the invite modal
    Feature.enable(:invite_members_group_modal)
  2. In rails console enable the experiment fully
    Feature.enable(:member_areas_of_focus)
  3. Visit any group or project member pages such as http://127.0.0.1:3000/groups/flightjs/-/group_members
  4. Click invite members button.

-->

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah