Skip to content

Vue shared comonents settings block h4 expand

What does this MR do?

This MR adds classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only to the h4 header Group Settings / Packages & Registries header Package Registry. This enables the expand/collapse behavior on mouse-click / tap for the h4 header.

The change is done via Vue shared component settings/settings_block.vue. This comontend is used by Group Settings / Packages & Registries and by Project Settings / Packages & Registries.

Related to issue #334655 (closed) reported by @mle.

Screenshots (strongly suggested)

Current behavior: no on-click / on-tap expand/collapse

Screenshot_2021-08-27_at_16.08.09

Behavior after applying this MR: on-click / on-tap expand/collapse

Screen_Recording_2021-08-28_at_08.06.20

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Daniel Schömer

Merge request reports