Removes subtransaction in internal id generator
What does this MR do?
InternalId
has 2 generators: InternalIdGenerator
and ImplicitlyLockingInternalIdGenerator
depending on the feature flag.
This MR changes both so that record creation does not need a subtransaction.
This uses Rails' insert_all
which does an INSERT
with ON CONFLICT .. DO NOTHING
.
This is behind the use_insert_all_in_internal_id
feature flag.
How to setup and validate locally (strongly suggested)
This can be tested by:
-
Create a new project
project = FactoryBot.create(:project, path: 'some-test-path', group: Group.first)
-
Create an issue in the project
FactoryBot.create(:issue, project: project)
Verify that there are no SAVEPOINT
and RELEASE SAVEPOINT
calls around the insert to internal_ids
. Other SAVEPOINT
calls you see there are already fixed in other MRs.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #338979 (closed)