Skip to content

Removes subtransaction in internal id generator

What does this MR do?

InternalId has 2 generators: InternalIdGenerator and ImplicitlyLockingInternalIdGenerator depending on the feature flag.

This MR changes both so that record creation does not need a subtransaction.

This uses Rails' insert_all which does an INSERT with ON CONFLICT .. DO NOTHING.

This is behind the use_insert_all_in_internal_id feature flag.

How to setup and validate locally (strongly suggested)

This can be tested by:

  1. Create a new project

    project = FactoryBot.create(:project, path: 'some-test-path', group: Group.first)
  2. Create an issue in the project

    FactoryBot.create(:issue, project: project)

Verify that there are no SAVEPOINT and RELEASE SAVEPOINT calls around the insert to internal_ids. Other SAVEPOINT calls you see there are already fixed in other MRs.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338979 (closed)

Edited by Heinrich Lee Yu

Merge request reports