Skip to content

UI for False Positive Identification

- requested to merge 336024-vet-frontend into master

Notes

  • Behind a feature flag :vulnerability_flags. graphQL @include directive used to feature flag out falsePositive field.
  • Done as a single MR intentionally at the advisement of the team and initial refinement. Turned out to be a more involved than anticipated.
  • Adds False positive support to Instance, Group, and Project level dashboards.
  • Adds False positive to MR widgets Vulnerability Modal
  • Adds false positive to Pipeline Security Tab

What does this MR do?

Project export for running locally

2021-09-06_16-22-863_ssarka_test-false-positive_export.tar.gz

Steps

  1. Import project
  2. In CI/CD make sure you have a gitlab runner active for the project
  3. Run the pipeline on master
  4. Run the pipeline on the merge request branch in the project
  5. Add the project to a group, and add it as a project at the instance level

Video Demos

Feature Flag Video Demo
Off https://youtu.be/kcAL_NKCwMw
On https://youtu.be/Tu3gTa8p4uc

Screen_Shot_2021-08-20_at_12.09.32_AM

Screen_Shot_2021-08-20_at_12.34.18_AM

Screen_Shot_2021-08-20_at_12.57.51_AM

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #336024

Edited by Taylor McCaslin

Merge request reports