Skip to content

Respect namespaces with unlimited minutes

Allison Browne requested to merge unlimited-zero-minutes-fix-2 into master

What does this MR do?

In incident 5392 we found that the gitlab security project was marked as running out of minutes.

All internal gitlab owned projects typically have unlimited minutes by way of namespace.shared_runners_minutes_limit == 0.

When this MR was introduced it broke skipping calculations on namespaces with 'unlimited minutes' in the track live consumption service. We introduced another check to return the same kind of error response to skip cost factor calculations.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Allison Browne

Merge request reports