What does this MR do?
getAction is undefined bug. This happens when
EditorMarkdownExtension receives a different instance argument. The problem is that the "Review" tab of WebIDE creates a CodeEditor instance for Source Editor, while both the "Review" and "Commit" are dealing with the DiffEditor instances.
We do not want Markdown preview on the files when in DiffEditor. This MR addresses this issue and completely avoids Markdown extension when setting up a DiffEditor instance.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
- Create or navigate to a project
- Click on Repository
- Click on WebIDE
- Make sure to have a
markdownfile (such as README.md)
- Navigate between edit and review modes
Actual: Throws an error with
getAction is undefined message
Expected: There should be no error.
Does this MR meet the acceptance criteria?
I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
I have added/updated documentation, or it's not needed. (Is documentation required?)
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
I have self-reviewed this MR per code review guidelines.
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
I have followed the style guides.
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
I have tested this MR in all supported browsers, or it's not needed.
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
Label as security and @ mention
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team