Skip to content

BulkImports: Handle network errors

Kassio Borges requested to merge kassio/bulkimports-handle-network-errors into master

What does this MR do?

Add BulkImports::NetworkError to wrap network exceptions from BulkImports::Client::Graphql and BulkImports::Client::HTTP. The wrapper has a #retriable? method that returns true when the exception is something worth retrying, like a timeout, and didn't happen more than BulkImports::NetworkError::MAX_RETRIABLE_COUNT, currently 3. The counter is scoped by:

  • the exception type;
  • BulkImports::Tracker;
  • BulkImports::Entity and;
  • BulkImports::Stage.

Related to: #262024 (closed)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports