Migration spec should run #down
What does this MR do?
Migration specs are found in spec/migrations
and are tagged with :migration
and schema: 12345
metadata. Inside the example the developer performs a migrate!
command to initiate the #up
on the migration. In order to perform the #up
the schema must first be downgraded through the #down
as called by before(:context, :migration)
and before(:each, :migration)
hooks in spec/support/migration.rb
.
Unfortunately the #down
on the defined schema
was never actually called. Before this MR the downgrade was performed as a downward migration process via migration_context.down(migration_schema_version)
. This down operation will reverse all migrations from the current version through to, but not including, the requested version. Here is the code where Rails skips the last schema downgrade.
- This MR will downgrade and upgrade only the schema defined in the
schema
metadata. - This will not rollback all other migrations between the current schema version and itself.
- I have introduced a
spec/fixtures/migrate
directory to be included by migration specs for the purposes of testing the migration framework.
This could also represent a performance boost for database migrations. Especially specs for much earlier migrations that would have otherwise been forced to roll back a huge percentage of the schema.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team