Skip to content

Restore use_transactional_tests value after delete

Heinrich Lee Yu requested to merge fix-delete-cleanup into master

What does this MR do?

This is needed for specs that have the :delete metadata on a specific example and not on the whole file / class.

Without this, succeeding tests in the same file would run without any transaction wrapper and without any DB cleanup.

Failure can be reproduced using:

bin/rspec ee/spec/services/ci/minutes/update_project_and_namespace_usage_service_spec.rb ee/spec/workers/admin_emails_worker_spec.rb

Related to #338843 (closed)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports