Reorder vuln check criteria

Merged Sam White requested to merge protect-reorder-vuln-check into master

What does this MR do?

This MR improves the order in which the Vulnerability-Check criteria is shown. Additionally, this MR adds and updates documentation for Vulnerability-Check.

Related issue: #338847 (closed) and #338944 (closed)

Screenshots or Screencasts (strongly suggested)

Before

approvals_before

After

approvals_after

Popup vulnerability related

Screen_Shot_2021-08-19_at_3.12.47_PM

Screen_Shot_2021-08-19_at_3.13.08_PM

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Zamir Martins