Skip to content

Add confirmation modal when pipeline failed [RUN AS-IF-FOSS]

Payton Burdette requested to merge 332593-confirmation-modal-merge-trains into master

What does this MR do?

Add a confirmation modal if a user tries to start a merge if the latest pipeline has failed. This confirmation is should only show for merge trains.

Related to: #332593 (closed)

Screenshots or Screencasts (strongly suggested)

merge-train-confirmation

How to setup and validate locally (strongly suggested)

  • Ensure normal merge on MR works
  • Setup merge trains on project with MR and test with a failed pipeline. Modal should show and after confirming start train as normal

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332593 (closed)

Edited by Payton Burdette

Merge request reports