Upsell the GitLab Terraform feature - tracking
What does this MR do?
The aim of this MR is to add tracking events for the Gitlab-managed Terraform state banner. We are adding two events:
- Docs link clicked
- Banner dismissed
Screenshots or Screencasts (strongly suggested)
There are no visual changes. Adding a screenshot for the context.
How to setup and validate locally (strongly suggested)
- Create the project that contains Terraform code (it should be in the top 5 languages)
- See the Terraform banner on the top of the project page
- Click on the docs link or close button and verify the Snowplow events
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
- [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. - [-] This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #338666 (closed)
Merge request reports
Activity
changed milestone to %14.3
assigned to @anna_vovchenko
- A deleted user
added product intelligence product intelligencereview pending labels
- A deleted user
added frontend label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
For the following files, a review from the Data team and Product Intelligence team is recommended
Please check the product intelligence guide.app/assets/javascripts/projects/terraform_notification/components/terraform_notification.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Peter Hegman ( @peterhegman
) (UTC-7)Simon Knox ( @psimyn
) (UTC+10)product intelligence Rajendra Kadam ( @rkadam3
) (UTC+5.5)Maintainer review is optional for product intelligence To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 84c13147 and 9d6d948d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.12 MB 3.09 MB -33.13 KB -1.0 % mainChunk 1.85 MB 1.85 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.merge_requests.creations.new 2.38 MB 2.48 MB +98.5 KB 4.0 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.security.dast_configuration 7.91 MB 1.69 MB -6.22 MB -78.6 % pages.projects.security.api_fuzzing_configuration 7.87 MB 1.65 MB -6.22 MB -79.0 % pages.groups.roadmap.show 2.56 MB 2.48 MB -80.22 KB -3.1 % pages.groups.epics.index 2.61 MB 2.54 MB -72.01 KB -2.7 % pages.groups.epics.show 3.12 MB 3.05 MB -71.84 KB -2.2 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermarked the checklist item I have included changelog trailers, or none are needed. (Does this MR need a changelog?) as completed
Allure report
allure-report-publisher
generated test report for 9d6d948d!review-qa-smoke:
test report- Resolved by Olena Horal-Koretska
@agarciatesares, could you please take a look from the product intelligence perspective?
@pburdette, could you please take the first round of the frontend review?
requested review from @agarciatesares and @pburdette
added product intelligenceapproved label and removed product intelligencereview pending label
@agarciatesares
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @agarciatesares
- A deleted user
added product intelligencereview pending label and removed product intelligenceapproved label
- Resolved by Anna Vovchenko
removed review request for @pburdette
requested review from @ohoral
- Resolved by Olena Horal-Koretska
added product intelligenceapproved label and removed product intelligencereview pending label
mentioned in commit e7d455f2
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request !68064 (merged)
added releasedpublished label and removed releasedcandidate label
added groupenvironments label and removed groupconfigure [DEPRECATED] label