DevOps Adoption - Add an adoption table in the Overview tab
What does this MR do?
This MR adds an adoption table to the DevOps Adoption overview tab. The table shows individual groups and their percentage of adopted features.
Screenshots or Screencasts (strongly suggested)
Admin view
Desktop | Mobile |
---|---|
![]() |
![]() |
Group view
Desktop | Mobile |
---|---|
![]() |
![]() |
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #335638 (closed)
Merge request reports
Activity
changed milestone to %14.3
assigned to @blabuschagne
removed workflowready for development label
- A deleted user
added frontend label
3 Warnings 21b76148: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2b534864: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d332d3e6: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Scott Stern ( @sstern
) (UTC-7, 9 hours behind@blabuschagne
)Savas Vedova ( @svedova
) (UTC+3, 1 hour ahead of@blabuschagne
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fea18c21 and fed69e1c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.14 MB 3.13 MB -14.52 KB -0.5 % mainChunk 1.87 MB 1.85 MB -11.96 KB -0.6 % Significant Reduction: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.subscriptions.buy_storage 871.35 KB 3.54 KB -867.81 KB -99.6 % sentry 150.91 KB 143.14 KB -7.77 KB -5.2 %
Note: We do not have exact data for fea18c21. So we have used data from: 68ee227a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for fed69e1c!review-qa-smoke:
test report- Resolved by Brandon Labuschagne
requested review from @npost
added Technical Writing label
added 304 commits
-
9293c681...6dc9163f - 302 commits from branch
master
- 4620caed - Add DevOps Adoption Overview table
- e03080a4 - Apply UX suggestions
-
9293c681...6dc9163f - 302 commits from branch
@npost
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 224 commits
-
e03080a4...3177ec13 - 221 commits from branch
master
- 96e8759b - Add DevOps Adoption Overview table
- a39a1f71 - Apply UX suggestions
- 6a6cab48 - Add test coverage
Toggle commit list-
e03080a4...3177ec13 - 221 commits from branch
- Resolved by Paul Slaughter
requested review from @pslaughter and removed review request for @mgandres
- Resolved by Paul Slaughter
Looking at this now!
- Resolved by Brandon Labuschagne
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
added 492 commits
-
6a6cab48...5f1b1e71 - 488 commits from branch
master
- 4ef1748a - Add DevOps Adoption Overview table
- 41b54c15 - Apply UX suggestions
- ec2ce9d2 - Add test coverage
- e336fd8e - Apply maintainer feedback
Toggle commit list-
6a6cab48...5f1b1e71 - 488 commits from branch
mentioned in issue #339452 (closed)
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
issue (non-blocking): I noticed that this polls regularly which triggers the spinner. This was a bit surprising to me since everything would go away all of a sudden
Maybe we should only show the spinner if we're loading and have no data already?
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
- Resolved by Paul Slaughter
Thanks so much for the work on this @blabuschagne! It's really sweet
I left some non-blocking thoughts for you, but most notably some pre-merge suggestions:
Back to you!
removed review request for @pslaughter
requested review from @pslaughter