Skip to content

Update edit page to account for type parameter

Alexander Turinske requested to merge 321884-policies-edit-page into master

What does this MR do?

Update edit page to account for type parameter Alexander Turinske authored 2 hours ago

  • update the policy editor to conditionally show components based on policy type passed in
  • update tests

How to setup and validate locally (strongly suggested)

  1. Follow the Protect Onboarding task to be able to create network policies in kubernetes/cilium
  2. Follow the scan execution creation snippet to create some scan execution policies
  3. Turn on the :security_policies_orchestration_configuration feature flag
  4. Navigate to Security & Compliance => Policies
  5. Change the security policy project

Screenshots or Screencasts (strongly suggested)

Page Before After
Policies#new p_new No visual change. Everything works as expected
Policies#edit, container_policy p_edit_old p_edit_container_new (with !68317 (merged), but this is not dependent on it because this is all behind a feature flag anyways)
Policies#edit, scan_execution_policy p_edit_old image (with !68317 (merged), but this is not dependent on it because this is all behind a feature flag anyways)
ThreatMonitoring#new tm_new No visual change. Everything works as expected
ThreatMonitoring#edit, container_policy tm_edit_container No visual change. Everything works as expected

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338754 (closed) Related to #321884 (closed)

Edited by Alexander Turinske

Merge request reports