Geo: Replicate wiki and design HEAD ref if needed
What does this MR do?
A customer noticed the HEAD ref was missing in some wiki repositories on a Geo secondary site.
When the HEAD ref on a Geo secondary site does not match the HEAD ref on the primary, it's not a data loss risk. But we expect wiki verification to fail in that case.
Geo did not need to replicate the wiki repository HEAD ref before. Something changed recently, related to this issue and it seems we might need to replicate the HEAD ref now.
In any case, it is desirable to copy the HEAD ref during syncs, in case it is somehow out-of-sync. This is already done for project repos and snippet repos.
I thought we were going to need to backport this, but we need more information to support that. See #338634 (comment 655483419)
Related to #338634 (closed)
How to setup and validate locally (strongly suggested)
See #338634 (comment 655483419)
I triggered verification and syncs in Rails console manually because waiting for automatic reverification/resync can take a very long time. I also went in and modified Git repos manually to try to reproduce bad states that this would fix. I had to disable Praefect because Praefect would also get into bad states during my tests. I think the customer was likely not using Praefect.
I don't have a quick way to test this. I don't really think it's absolutely necessary though, since this MR is mainly moving logic into a superclass so that it runs on all subclasses.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team