Upsell the GitLab Terraform features - iteration 3 frontend
What does this MR do?
As part of iteration 2 (the first iteration is here) we have changed the GitLab-managed Terraform state banner:
- changed the banner design from
introduction
topromotion
- added illustration to make it prominent that the banner is about Terraform
- changed the logic of managing the banner from per-project to per-user basis
- as the result, it is possible to use
UserCalloutDismisser
as was suggested by @ohoral.
Update We want to split the task to ship the change safely for the mixed deployment scenario.
We decided to proceed in 3 steps:
- Change the design using the old logic
- Introduce the backend change
-
Then in 14.3 switch to the new implementation using
UserCalloutDismisser
- current step
Current MR:
- changes the banner implementation to use
UserCalloutDismisser
Screenshots or Screencasts (strongly suggested)
There will be no visual changes as the design should be changed in another MR.
How to setup and validate locally (strongly suggested)
- Create a project that contains Terraform files (.tf files should be at least in the top 5 files types)
- View the banner on the top
- After dismissing the banner try to reload the page and go to another project that contains Terraform files. Verify that the banner is not shown anymore.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #336252 (closed)
Edited by Anna Vovchenko