Skip to content

Remove class to fix dark mode readability

Miranda Fluharty requested to merge 336976-remove-text-secondary into master

What does this MR do?

For #336976 (closed)

This MR makes the class name and execution time fields in the unit test report summary MR widget's modal more readable (especially in dark mode) by removing the text-secondary class from them.

Screenshots

before 😑 after 😃
normal mode 👓 Screen_Shot_2021-08-12_at_14.41.14 Screen_Shot_2021-08-12_at_14.38.29
dark mode 🕶 Screen_Shot_2021-08-12_at_14.40.31 Screen_Shot_2021-08-12_at_14.39.12

How to setup and validate locally (strongly suggested)

  1. set up unit test reports for a project (or clone this testing project)
  2. open a merge request for a branch that changes the results of some unit tests (or for feature-branch in the testing project)
  3. ensure pipelines ran for both the base commit and head commit of the merge request's branch
  4. navigate to the merge request and expand the unit test report widget
  5. click one of the tests in the lists to open the modal

Does this MR meet the acceptance criteria?

Conformity

Edited by Miranda Fluharty

Merge request reports