Skip to content

Fix adding or updating vulnerability history comments

Savas Vedova requested to merge svedova-fix-history-entry-bug into master

What does this MR do?

Adding or updating a vulnerability history comment creates a weird state where the comment is not displayed at all and a loading spinner spins indefinitely. The cause of this state is due to the property cases. The REST api returns snake_case whereas in the frontend we use camelCase. Converting the case fixed the bug.

Screenshots or Screencasts (strongly suggested)

Buggy version fixed
vulnerability-add-comment-bug fixed-bug

How to setup and validate locally (strongly suggested)

  1. Clone https://gitlab.com/gitlab-examples/security/security-reports/
  2. Run the pipeline by going into Your project > CI/CD > Pipelines
  3. Click on run pipeline for master branch
  4. Go to Security & Compliance > Vulnerability Report > Click on a Vulnerability
  5. Change the state, it will generate a history entry

You should have the runner installed in order to run the pipeline. Then using the following command you can register the runner, it guides you pretty good on how to set the runner:

$ gitlab-runner register

Once it's installed this is how I run the runner:

$ gitlab-runner --log-level debug run local-runner --config ~/.gitlab-runner/config.toml restart

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Savas Vedova

Merge request reports