Remove `jira_issue_association_on_merge_request` feature flag
What does this MR do?
This MR removes all the code related to the feature flag jira_issue_association_on_merge_request as described in #335280 (closed).
The feature flag was enabled by default %14.1 and we can now safely remove it.
Screenshots or Screencasts (strongly suggested)
| Disabled (without ticket) | Enabled (with ticket) | Enabled (without ticket) |
|---|---|---|
 |
 |
 |
How to setup and validate locally (strongly suggested)
- You need a GitLab Ultimate license
- Add a Jira integration in
[GDK_HOST]/gitlab-org/gitlab-shell/-/settings/integrations - Enable Merge requests > Require an associated issue from Jira in
[GDK_HOST]/gitlab-org/gitlab-shell/edit - Create a MR in that project that references a jira reference and verify that it can be merged
- Remove the jira reference and verify that it cannot be merged
- Disable Merge requests > Require an associated issue from Jira in
[GDK_HOST]/gitlab-org/gitlab-shell/edit - View the same merge request and verify that it can be merged without the jira reference
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #335280 (closed)
Edited by Jiaan Louw