Skip to content

release_highlights: cache relative paths

Jason Plum requested to merge 338288-whats-new-relateive-path into master

What does this MR do?

In #338288 (closed), we found that we were caching the full file paths.

Here we change it to cache only the relative paths. To do this, we strip Rails.root at the time of glob, and add it when we actually use file_path in load_items. We've also changed the cache key, so that we don't "tromp" on existing deployments.

Screenshots or Screencasts (strongly suggested)

See #338288 (closed) for links to logs.

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #338288 (closed)

Edited by Jason Plum

Merge request reports