Skip to content

Draft: Fail fast if issue count is too large for /api/v4/issues_statistics

Mario Celi requested to merge 330519-fail-fast-issues-statistics into master

What does this MR do?

Relates to #330519

This MR makes /api/v4/issues_statistics fail after N seconds (currently 10) and return -1 for all issue statistics counts instead of returning a 500 error after the globally defined 15 seconds of DB timeout.

If the approach is approved, we should probably document the returned -1 when the amount of issues is too large.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330519

Edited by Mario Celi

Merge request reports