Skip to content

Enable packages_nuget_new_package_file_updater by default

David Fernandez requested to merge 336511_enable_by_default into master

🛶 Context

The feature flag packages_nuget_new_package_file_updater controls how NuGet package uploads are processed by a background job. This refactoring was need to fix an issue when uploading large files.

See #321361 (comment 622762440) and !66728 (merged) for all the details.

This feature has been rolled out on gitlab.com without any hiccup. See the rollout issue: #336511 (closed).

No errors detected on this dashboard (internal):

Screenshot_2021-08-16_at_09.29.29

It's time to enable the feature flag by default.

We're not removing the feature flag (and related code) yet because self-managed users might have a rather different configuration for object storage than gitlab.com. They can thus experience issues even though we tested several different configurations. Keeping the feature flag is a safety net for them: if they hit an issue with this part, they can simply disable it.

🔬 What does this MR do?

  • Enable packages_nuget_new_package_file_updater by default.

🖼 Screenshots or Screencasts (strongly suggested)

n / a

🛀 How to setup and validate locally (strongly suggested)

n / a

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports