Skip to content

Refactor bulk imports table to use GlTable

Illya Klymov requested to merge xanf-refactor-bulk-import-to-gl-table into master

What does this MR do?

In preparation of adding "checkboxes" as a part of #267953 (closed) we are refactoring table rendering from rendering table -> tr -> td manually to utilizing GlTable.

This MR does add any new functionality and it's main purpose is to make sure we're not breaking any related QA spec by such switch.

Screenshots or Screencasts (strongly suggested)

Before After
image image

Intended changes:

  • Minor tweaks to table header spacing

How to setup and validate locally (strongly suggested)

  • Enable feature bulk_import via Feature.enable(:bulk_import)
  • Open "New group" (/groups/new)
  • Use https://gitlab.com as source instance and GeK1Nis4j-SY1X4sqE5c as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here)
  • Modify any dropdown to target existing project (note: right now this is case sensitive, it is known issue and out of scope of this MR) lete any tasks that are not applicable. -->

Conformity

Availability and Testing

Merge request reports