Add container registry migration eligibility flag to all tokens regardless of action [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
In !63907 (merged) we introduced the required logic to drive the upcoming container registry migration using Rails feature flags (#335260 (closed)). We do so by modifying the JWT tokens that Rails emit and are then sent to the registry with every request. The modified tokens include a special migration_eligible flag which will tell the registry whether a new container repository should be migrated or not.
Initially, we planned to only include this flag in tokens that granted push permissions but now we realized we need them to be present for tokens with pull permissions as well, otherwise, the registry does not know how to serve the requests.
This MR modifies the changes introduced in !63907 (merged) to ensure that the migration_eligible flag is included in all tokens and not just the ones with push permissions. This logic continues to sit behind a feature flag introduced in !63907 (merged).
How to setup and validate locally (strongly suggested)
Please see the instructions in !63907 (merged). The expected results are similar, with the exception that tokens with just the pull scope should also be modified and have the migration_eligible flag in their body.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team