Skip to content

Deployment rollback modal: Change form submit to POST

What does this MR do?

This MR fixes a regression introduced in !66808 (merged).

As noted in !66808 (comment 646353113), clicking on Rollback button in the modal, results in submitting the retry request via GET as opposed to a POST method. This MR adds a form to the modal and ensures that the form is submitted via POST.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Martin Wortschack

Merge request reports