Skip to content

Make filters work for pipeline dashboard

Savas Vedova requested to merge 331401-implement-filtering-functionality into master

What does this MR do?

This MR does two things:

  1. It adds the router to the pipeline dashboard app so that filters are persisted in the URL
  2. Adds the state parameter so that users can filter results using the state parameter.

Screenshots or Screencasts (strongly suggested)

pipeline-filters

How to setup and validate locally (strongly suggested)

  1. Clone https://gitlab.com/gitlab-examples/security/security-reports/
  2. Run the pipeline by going into Your project > CI/CD > Pipelines
  3. Click on run pipeline for master branch
  4. Go to Project > CI/CD > Pipelines > Your Pipeline > Security Tab

You should have the runner installed in order to run the pipeline. Then using the following command you can register the runner, it guides you pretty good on how to set the runner:

$ gitlab-runner register

Once it's installed this is how I run the runner:

$ gitlab-runner --log-level debug run local-runner --config ~/.gitlab-runner/config.toml restart

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331401 (closed)

Merge request reports