Skip to content

Add support for adding attachments in Content Editor

Himanshu Kapoor requested to merge 335114-content-editor-attachments into master

What does this MR do?

Adds support for uploading files as attachments in content editor in wikis.

Issue: #335114 (closed)

Screenshots or Screencasts (strongly suggested)

State Screenshot
Initial state: click on link dropdown image
Uploading an attachment (in progress) image
Attachment uploaded successfully image
Uploading an image (in progress) image
Image uploaded successfully image
When a link is selected, does not show the upload file option; shows "remove link" instead image
Error state: file upload failed image

How to setup and validate locally (strongly suggested)

  1. Open wikis for any project.
  2. Edit or create a new page.
  3. Click Use the new editor button to switch to content editor.
  4. Click "Upload file" under the link dropdown to upload a file or an image. You can also click "Upload image" under the image dropdown to upload an image.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #335114 (closed)

Edited by Himanshu Kapoor

Merge request reports