Fix connection search path being reset
What does this MR do?
RESET ALL
is reseting too many parameters, we should reset only the
parameter we just set, namely statement_timeout
https://www.postgresql.org/docs/12/sql-reset.html
In #337813 (closed), we are planning to use PostgreSQL
database schemas to separate tables. To do so in a backwards compatible way we need to set the
search_path
configuration parameter. Unfortunately, tests fail (example: https://gitlab.com/gitlab-org/gitlab/-/jobs/1484972168) because anytime we hit this method, all configuration parameters
are reset to their default values, all tests after that fails.
We should not be resetting all parameters anyway - we only need to reset the one that we just manipulated,
namely statement_timeout
.
Related issue: #337813 (closed)
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
Edited by Thong Kuah