Skip to content

Renames the Base terraform template jobs for better scaling

Viktor Nagy (GitLab) requested to merge nagyv-gitlab-master-patch-61887 into master

What does this MR do?

Renames the jobs of the Base terraform template. The current jobs have very generic names that can easily clash with other jobs, and make it hard to understand what they cover.

Current example:

include:
  - template: Terraform/Base.latest.gitlab-ci.yml

myjob:
  extends: .init

New example:

include:
  - template: Terraform/Base.latest.gitlab-ci.yml

myjob:
  extends: .terraform:init

The new syntax helps the user to understand what the job is about even months after it was written.

As this is a breaking change, the changes are introduced in the "latest" template only. This requires a new "stable" Base template too that is added as part of the MR.

Manual QA project

https://gitlab.com/nagyv-gitlab/qa-for-mr-67719

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports