Fix pipeline status layout in pipeline editor
What does this MR do?
This adds wrapping div
s to the loading and error templates of the pipeline status component so the elements are grouped together under the flex
layout.
Screenshots or Screencasts
Before | After |
---|---|
![]() |
![]() |
How to setup and validate locally
- You can view the pipeline editor for the project in
CI/CD > Editor
. - To view the loading state, reload the page or create a new commit using the form at the bottom of the editor.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- [-] I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
Merge request reports
Activity
changed milestone to %14.2
added devopsverify frontend grouppipeline authoring sectionops typebug labels
assigned to @mgandres
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sheldon Led ( @sheldonled
) (UTC+1, 7 hours behind@mgandres
)Jose Ivan Vargas ( @jivanvl
) (UTC-5, 13 hours behind@mgandres
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f55df3d8 and 8b93d5e1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.08 MB 3.08 MB - -0.0 % mainChunk 1.85 MB 1.85 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.compare.index 259.69 KB 270.79 KB +11.1 KB 4.3 % pages.projects.compare.show 305.6 KB 316.7 KB +11.1 KB 3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for f55df3d8. So we have used data from: b8376928.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report for 8b93d5e1!review-qa-smoke:
test report- Resolved by Jose Ivan Vargas
Hi @sheldonled could give this tiny MR a review?
requested review from @sheldonled
- Resolved by Jose Ivan Vargas
@sheldonled, thanks for approving this merge request.Please consider starting a new pipeline if:
- This is the first time the merge request is approved, or
- The merge request is ready to be merged, and there has not been a merge request pipeline in the last 2 hours.
For more info, refer to the guideline.
requested review from @jivanvl
This looks good to me! Thanks @mgandres
enabled an automatic merge when the pipeline for 6ff55fd6 succeeds
mentioned in commit 694619be
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!123 (merged)
mentioned in issue gl-retrospectives/verify-stage/pipeline-authoring#11 (closed)