Skip to content

Fix select2 form light borders

Alper Akgun requested to merge 337622-fix-trial-form-light-borders into master

What does this MR do?

Fix select2 form light borders in the trial form and elsewhere

Related to #337622 (closed) Item 1

https://select2.org/getting-started/basic-usage

  1. Make Gitlab.com? return true in lib/gitlab.rb

Screenshots or Screencasts

Trial Preferences
http://localhost:3000/-/trials/new http://localhost:3000/-/profile/preferences
Number of Employees & Country (select2) vs Company Name (input) Tab width (input) vs the others(select2)

Before

Trial Preferences
screenshot-2021-08-09-22-22-07 screenshot-2021-08-09-22-21-58

After

Trial Preferences
screenshot-2021-08-09-22-19-04 screenshot-2021-08-09-22-18-52

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun

Merge request reports