Skip to content

Extract runner registration service from endpoint [RUN-AS-IF-FOSS]

What does this MR do?

This MR extracts a Ci::RegisterRunnerService service from the code that exists in the /runners REST API endpoint so that it can later be reused by GraphQL and be better encapsulated.

Most of the examples were moved to the Ci::RegisterRunnerService specs. In the old specs we now only test that we pass the expected arguments to Ci::RegisterRunnerService, and we do some actual tests going through Ci::RegisterRunnerService for certain parameters (name version revision platform architecture ip_address).

The old specs were testing against ::Ci::Runner.first which seems non-sense to me, so I changed it to ::Ci::Runner.last, since that is what would match the most recently inserted record.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #335509 (closed)

Merge request reports