Skip to content

Remove scan_execution_policy_ui feature flag

Alexander Turinske requested to merge 273791-delete-feature-flag into master

What does this MR do?

Remove scan_execution_policy_ui feature flag

  • the scan_execution_policy_ui feature flag and the security_orchestration_policies_configuration feature flag serve he same purpose, so I am condensing them

Screenshots or Screencasts (strongly suggested)

Title Screenshot
With :scan_execution_ui disabled and :security_orchestration_policies_configuration disabled Screen_Shot_2021-08-05_at_4.31.26_PM
With :scan_execution_ui disabled and :security_orchestration_policies_configuration enabled Screen_Shot_2021-08-05_at_4.30.39_PM

How to setup and validate locally (strongly suggested)

  1. Navigate to a project
  2. Ensure the project has an environment created, or create one by going to Depyloyments => Environments => New Environment
  3. Navigate to Security & Compliance => Threat Monitoring => Policies => New Policy
  4. Verify a user cannot create a Scan Execution policy
  5. Toggle the :security_orchestration_policies_configuration feature flag on with Feature.enable(:security_orchestration_policies_configuration)
  6. Refresh the page
  7. Verify a user can create a Scan Execution policy

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273791 (closed)

Merge request reports