Append replies in email generated notes for issues
What does this MR do?
Related to #3780 (closed)
When handling service desk issue creation from emails, we are using Gitlab::Email::Handler::ReplyProcessing#message_including_reply to process the message. This would result in a service desk issue including a reply if present (any quoted text or content after a signature would be considered a reply in this case).
For Gitlab::Email::Handler::CreateNoteHandler we were using Gitlab::Email::Handler::ReplyProcessing#message instead, meaning that any reply would not be included in the note content. For this reason, some data could be lost when responding to service desk issues.
Although we could change it to use #message_including_reply, it was proposed to append the reply in a details block.
This MR introduces the new method Gitlab::Email::Handler::ReplyProcessing#message_with_appended_reply so that it can be replaced in CreateNoteHandler when the notable is an issue.
In cases when the note contains only quick commands, the reply would not be appended.
Screenshots or Screencasts (strongly suggested)
Screen_Recording_2021-08-05_at_18.16.18
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #3780 (closed)