Skip to content

Remove `GitlabSchema#execute`, and small tidy ups related to max limits

Luke Duncalfe requested to merge ld-simplify-gitlab_schema-execute into master

What does this MR do?

Graphql::Schema#execute calls #multiplex so we can remove our #execute.

How to setup and validate locally (strongly suggested)

  1. Open a private browsing window so you are an anonymous user.
  2. Change GitlabSchema::DEFAULT_MAX_COMPLEXITY to a low value, like 2
  3. Execute a query on GraphiQL Explorer http://127.0.0.1:3000/-/graphql-explorer
  4. The complexity limit should apply

  1. Log in as an admin user
  2. Change GitlabSchema::ADMIN_MAX_COMPLEXITY to a low value, like 3
  3. Execute a query on GraphiQL Explorer http://127.0.0.1:3000/-/graphql-explorer
  4. The complexity limit should apply

  1. Log in as a non-admin user
  2. Change GitlabSchema::AUTHENTICATED_MAX_COMPLEXITY to a low value, like 4
  3. Execute a query on GraphiQL Explorer http://127.0.0.1:3000/-/graphql-explorer
  4. The complexity limit should apply

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Luke Duncalfe

Merge request reports