Skip to content

Follow-up: Geo log cursor gap tracking improvements

Toon Claes requested to merge tc-geo-gap-tracking-improvements into master

What does this MR do?

It addresses the follow-up items from gitlab-org/gitlab-ee!6640:

  • @ash.mckenzie started a discussion: (+3 comments)

    private removed?

  • @ash.mckenzie started a discussion: (+2 comments)

    An example here of some values might assist?

  • @stanhu commented on a discussion: (+2 comments)

    I think we still need Gitlab::Geo::LogHelpers? I think @ash.mckenzie was saying we don't need geo_logger. I'll revert your last commit and remove that method.

  • @stanhu started a discussion:

    This could be an N+1 query. We might need to do this in batches.

Are there points in the code the reviewer needs to double check?

Are there still N+1 queries?

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ee#7057.

Edited by Toon Claes

Merge request reports