Rails 5 fix product array method delagation by manually calling .to_a in NotificationService
What does this MR do?
Fix NotificationService
for Rails 5. In Rails 5 blanket array delegation was removed, so recipients.product(alerts)
fails because product
is not in the explicitly delegated methods of Rails. An explicit .to_a
gives the same result.
spec that was failing: ee/spec/services/ee/notification_service_spec.rb:254
see https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/85910127
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
rails5 upgrade
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conforms to the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
EE specific content should be in the top level /ee
folder -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -
End-to-end tests pass ( package-and-qa
manual pipeline job)