Skip to content

Allow licenses with a 10% overage of users for renewals

What does this MR do?

Part of #333851 (closed)

There already was a 10% overage allowance on users count when applying a new license (no renewals). Now, the same overage will be applied to all license uploads for the users count including renewals.

How to setup and validate locally (strongly suggested)

For new license: Create a license that is for less than the users in your instance but would meet the count when adding 10% to it. In my tests, the instance had 52 users, so the created license had 48 users (10% are 4 users so 52 would be met).

For renewal: Do the same but create the license with a number in Previous users count, in my case that was 40.

Then try uploading the licenses.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Corinna Gogolok

Merge request reports