Move the container registry visibility setting to _not_ be nested within the Repository visibility setting
What does this MR do?
Currently, the Container Registry visibility setting is nested within the Repository visibility setting. Setting the Repository to private forces the Container Registry to also be private. Disabling the Repository also disables the Container Registry toggle button. But these changes do not actually happen on the backend. Also, via the public API, we can disable the Repository while keeping the Container Registry enabled. Container Registry visibility should not be affected by Repository visibility since they are completely separate features.
This MR:
- Moves the Container Registry visibility setting so that it is not nested within the Repository setting
- Changes the Container Registry visibility setting to not be affected by the Repository setting.
- Since the CI/CD setting is affected by the Repository visibility, I've moved it into the Repository
div, so that it gets nested under Repository.
Screenshots or Screencasts (strongly suggested)
| Before | After |
|---|---|
 |
 |
| container_registry_setting_ui_before_move | container_registry_setting_ui_after_move |
How to setup and validate locally (strongly suggested)
- Open any project in GDK.
- Go to Settings > General > Visibility, project features, permissions.
- Try toggling the Container Registry and Repository settings.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - I have tested this MR in all supported browsers, or it's not needed.
- I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- Label as security and @ mention
@gitlab-com/gl-security/appsec - The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- Security reports checked/validated by a reviewer from the AppSec team
Related to #18792 (closed)