Draft: Secure scan usage metrics count non successful builds
What does this MR do?
Update Secure Usage Ping metrics user_[analyzer name]_scans
and [analyzer name]_pipeline
to count scans associated with non-successful builds or retried builds. Previously these would not be counted.
The purpose of this MR is to reduce load on the GitLab Rails database by removing a join with the ci_builds
table. This frees up the database sharding team to move the table to a new database.
Scans that are part of failed builds are still scans, so arguably this change is conceptually correct. For example, some users prefer to fail CI builds that run a scan where the scan finds vulnerabilities. These are valid scans, and therefore should be counted in Secure metrics.
This MR resolves issue #336170 (closed).
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Cameron Swords