Skip to content

Allow usage of severity quickaction on create

Sean Arnold requested to merge 332594-allow-severity-quickaction-on-create into master

What does this MR do?

This makes some changes to allow the /severity quick-action to be used when creating an Incident via the new Incident UI.

Previously this behaviour would 500 due to the code ending up in a loop.

The downside of this change, is that we cannot determine the type of issue before the form has been submitted. That means to show the autocomplete logic of the /severity quick-action we need to enable it for all issues. Upon creation of the issue however, no severity is saved. Since we do not show severity for non-incident issues I don't think this is a problem.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Before After
2021-08-03_14.45.24 2021-08-03_14.23.01
  1. Create an incident via Monitor -> Incidents -> New Incident, or via the new Issues page.
  2. On the creation form, use the /severity quick-action i.e /severity 3.
  3. The incident will be created and the chosen severity will be set.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #332594 (closed)

Edited by Sean Arnold

Merge request reports