Skip to content

Override elasticsearch setting for STI note models

Jan Provaznik requested to merge jprovazn-elastic-inherited into master

What does this MR do?

It overrides elasticsearch variables to assure that Note's subclasses use same index and mapping.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

elasticsearch-rails 0.1.9 doesn't support STI properly. Although overriding class instance variables is not ideal, it's best option at the moment. Alternatives are:

  • define explicitly index_name, document_type and mappings in each subclass (which would be annoying given the fact we have a concern for this already)
  • upgrade to elasticsearch-rails version 5.x - newer versions already supports enabling inheritance https://github.com/elastic/elasticsearch-rails/tree/master/elasticsearch-model#settings but I'm not convinced about usability/stability of the newer version at this point. I couldn't make this working together with module include we use, also I was hitting errors stack level too deep which is known one (https://github.com/elastic/elasticsearch-rails/issues/792) and would require additional workarounds. - I think it makes sense to create a follow-up issue for switching to 5.x version one/two cycles later (also after we switch to rails 5).

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #5705 (closed)

Edited by Nick Thomas

Merge request reports