Rubocop Cop that avoids building a subquery with attribute_names
requested to merge 336461-consider-a-rubocop-rule-that-avoids-building-a-subquery-with-attribute_names into master
What does this MR do?
Discourages use of methods that enumerate the column names on a table as their use in queries can lead to uneven queries as seen in gitlab-com/gl-infra/production#5171 (comment 628068466)
- Alerts when
column_names
andattribute_names
are used outside ofspecs
andqa
tests. - This is a pretty blunt check and since we only have one false positive showing up in the database, this seems like the most straightforward approach at early detection.
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #336461
Edited by Doug Stull