Move "Save" in separate row for Profile and Preference settings pages
What does this MR do?
Extend the last row of the Profile and Preferences settings pages to have the "Save" button as it's own area.
The current location of "Save" looks like it is part of the last section rather than the page.
Screenshots or Screencasts (strongly suggested)
-/profile
| Before | After |
|---|---|
 |
 |
-/profile/preferences
| Before | After |
|---|---|
 |
 |
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
assigned to @mle
- A deleted user
added frontend label
4 Warnings 
8094efed: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Peter Hegman ( @peterhegman) (UTC-7, 17 hours behind@mle)Illya Klymov ( @xanf) (UTC+3, 7 hours behind@mle)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Resolved by Michael Le@gitlab-com/gitlab-ux/ux-foundations I created this MR to solve the issue that the "save" button location for settings pages with one save button but multiple sections.
I personally struggled in the past to find the save button when changing settings for these types of pages because I don't know where the save button was.
- Last reply by Michael Le
requested review from @dstull
- Resolved by Michael Le
Hi @dstull Could you please provide a review of this change from the frontend perspective?
One area that could raise an issue is how I used the CSS utility classes. There are a lot of classes and I don't know if I should place them in any specific order.
- Last reply by Michael Le
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8263433e and 8094efed
Entrypoint / Name Size before Size after Diff Diff in percent average 3.09 MB 3.08 MB -13.64 KB -0.4 % mainChunk 1.85 MB 1.85 MB -3.89 KB -0.2 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.epic_boards 2.05 MB 2.7 MB +672.77 KB 32.1 % pages.projects.security.configuration 1.51 MB 1.7 MB +200.23 KB 13.0 % pages.admin.runners.index 1.21 MB 1.39 MB +179.59 KB 14.5 % pages.projects.compare.index 259.62 KB 270.79 KB +11.17 KB 4.3 % pages.projects.compare.show 305.53 KB 316.7 KB +11.17 KB 3.7 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.security.policies.show 0 Bytes 987.03 KB +987.03 KB 100.0 % pages.groups.seat_usage.show 0 Bytes 485.72 KB +485.72 KB 100.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.commit.pipelines 1.02 MB 416.44 KB -623.44 KB -60.0 % pages.groups.usage_quotas 1.28 MB 959.63 KB -347.3 KB -26.6 % pages.projects.clusters.index 1.24 MB 1.02 MB -219.24 KB -17.3 % pages.admin.integrations.overrides 171.21 KB 18.53 KB -152.69 KB -89.2 % pages.import.bulk_imports.status 1.02 MB 895.52 KB -147.06 KB -14.1 % pages.projects.cycle_analytics.show 403.1 KB 387.36 KB -15.74 KB -3.9 % pages.admin.dev_ops_report 185.43 KB 175.75 KB -9.68 KB -5.2 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov,@justin_ho,@mikegreilingor@nmezzopera) for review, if you are unsure about the size increase.Note: We do not have exact data for 8263433e. So we have used data from: adb627b6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report for 8094efed!review-qa-smoke:
added 1 commit
- 5d142dd0 - Sticky footer for Profile and Preference settings
removed review request for @dstull
added 620 commits
-
5d142dd0...be7d47b0 - 619 commits from branch
master - 83d158ca - Full width footer for Profile and Preference settings
-
5d142dd0...be7d47b0 - 619 commits from branch
requested review from @cngo
- Resolved by Savas Vedova
@cngo Hi Coung! Could you review this merge request from a front end perspective? Thanks!
- Last reply by Coung Ngo
removed review request for @cngo
requested review from @cngo
@cngo, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in commit bdf91edb
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
